Journaling for all flights

backend/app/crud/crud_arrival.py

@@ -4,6 +4,8 @@ from sqlalchemy import and_, or_, func, desc
 from datetime import date, datetime
 from app.models.arrival import Arrival, ArrivalStatus
 from app.schemas.arrival import ArrivalCreate, ArrivalUpdate, ArrivalStatusUpdate
+from app.models.journal import EntityType
+from app.crud.crud_journal import journal
 
 
 class CRUDArrival:
@@ -56,16 +58,43 @@ class CRUDArrival:
         db.refresh(db_obj)
         return db_obj
 
-    def update(self, db: Session, db_obj: Arrival, obj_in: ArrivalUpdate) -> Arrival:
+    def update(self, db: Session, db_obj: Arrival, obj_in: ArrivalUpdate, user: str = "system", user_ip: Optional[str] = None) -> Arrival:
+        from datetime import datetime as dt
+        
         update_data = obj_in.dict(exclude_unset=True)
+        changes = []
         
         for field, value in update_data.items():
-            if value is not None:
+            old_value = getattr(db_obj, field)
+            
+            # Normalize datetime values for comparison (ignore timezone differences)
+            if isinstance(old_value, dt) and isinstance(value, dt):
+                # Compare only the date and time, ignoring timezone
+                old_normalized = old_value.replace(tzinfo=None) if old_value.tzinfo else old_value
+                new_normalized = value.replace(tzinfo=None) if value.tzinfo else value
+                if old_normalized == new_normalized:
+                    continue  # Skip if datetimes are the same
+            
+            if old_value != value:
+                changes.append(f"{field} changed from '{old_value}' to '{value}'")
                 setattr(db_obj, field, value)
         
-        db.add(db_obj)
-        db.commit()
-        db.refresh(db_obj)
+        if changes:
+            db.add(db_obj)
+            db.commit()
+            db.refresh(db_obj)
+            
+            # Log changes in journal
+            for change in changes:
+                journal.log_change(
+                    db,
+                    EntityType.ARRIVAL,
+                    db_obj.id,
+                    change,
+                    user,
+                    user_ip
+                )
+        
         return db_obj
 
     def update_status(
@@ -73,12 +102,15 @@ class CRUDArrival:
         db: Session, 
         arrival_id: int, 
         status: ArrivalStatus,
-        timestamp: Optional[datetime] = None
+        timestamp: Optional[datetime] = None,
+        user: str = "system",
+        user_ip: Optional[str] = None
     ) -> Optional[Arrival]:
         db_obj = self.get(db, arrival_id)
         if not db_obj:
             return None
         
+        old_status = db_obj.status
         db_obj.status = status
         
         if status == ArrivalStatus.LANDED and timestamp:
@@ -87,6 +119,17 @@ class CRUDArrival:
         db.add(db_obj)
         db.commit()
         db.refresh(db_obj)
+        
+        # Log status change in journal
+        journal.log_change(
+            db,
+            EntityType.ARRIVAL,
+            arrival_id,
+            f"Status changed from {old_status.value} to {status.value}",
+            user,
+            user_ip
+        )
+        
         return db_obj
 
     def cancel(self, db: Session, arrival_id: int) -> Optional[Arrival]: